Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests examples #4249

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Add tests examples #4249

merged 4 commits into from
Oct 11, 2023

Conversation

tadeuah
Copy link
Contributor

@tadeuah tadeuah commented Oct 10, 2023

What are you changing in this pull request and why?

These changes in test-selection-examples.md are intended to increase the number of examples for running tests, considering that when I worked a lot with tests, I did not find an example of how to run two or more specific tests on models or sources.

@tadeuah
add-more-tests-examples
f7f79e4 
These changes are intended to increase the number of examples for running tests, considering that when I worked a lot with tests, I did not find an example of how to run two or more specific tests on models or sources.
@tadeuah tadeuah requested a review from a team as a code owner October 10, 2023 23:55
@welcome
Copy link

welcome bot commented Oct 10, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 10:21am

@github-actions github-actions bot added the content Improvements or additions to content label Oct 10, 2023
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 10, 2023
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Oct 10, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 11, 2023
mirnawong1
mirnawong1 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @tadeuah , great addition to the examples and really appreciate your contribution! I'll get this merged and also made some changes to remove the $ symbol as users mentioned it's not helpful when copying/pasting code. looking forward to future contributions ✨

@mirnawong1 mirnawong1 enabled auto-merge October 11, 2023 10:15
@mirnawong1 mirnawong1 merged commit 3a9d15e into dbt-labs:current Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadeuah @mirnawong1 @runleonarun